Project

General

Profile

Bug #129

Window "No backend engines found!" will not appear if there is no engines

Added by Vladimir Martyanov almost 5 years ago. Updated over 4 years ago.

Status:
Feedback
Priority:
Low
Category:
Bokken UI
Target version:
Start date:
26/08/2012
Due date:
% Done:

50%

Severity:
Minor

Description

If cores weren't found, we will have a message in console and termination of bokken (ui/dependency_check.py, cores()).

Solution: removal of sys.exit(1) in cores() and addition of engines check before ui.* imports in ui/main.py

changes.diff Magnifier (1.28 KB) Vladimir Martyanov, 26/08/2012 18:08

changes.patch Magnifier (10.2 KB) Vladimir Martyanov, 05/11/2012 13:04

changes2.patch Magnifier (6.28 KB) Vladimir Martyanov, 05/11/2012 13:04

History

#1 Updated by Vladimir Martyanov almost 5 years ago

diff-file attached

#2 Updated by David Martínez Moreno almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Vladimir Martyanov

No, the problem is that Bokken can be instantiated from a windowing system (either in Windows or a graphical environment in Linux) so you will see a flashing window and just that.

I think it's much better to maybe add just a pause to press Enter (and thus block the window). Do you want to do that?

#3 Updated by Vladimir Martyanov almost 5 years ago

Hm... I didn't think about starting bokken not from console :-)

How do I see error messages: if we have GTK we use GTK (and maybe console in some cases) to display error messages.
If we can't use GTK to display errors (no GTK or other problems with GUI) we will use console output and wait ENTER key before program termination to let user see errors even if bokken wasn't started from console.
In Windows ANSI-sequences will not be used because they just doesn't work and user will see strange characters instead of coloured text :-(

What do you think about it?

#4 Updated by David Martínez Moreno almost 5 years ago

  • Category set to Bokken UI
  • Status changed from In Progress to Feedback
  • Target version set to 2.0

All right, so in order to have a proper description of the bug, I need you to explain exactly what you're seeing.
In Windows Bokken is run through bokken.bat, and that should start a command-line instance, so if you pause to read a key, that should be visible. Could you please try that?
What I think it could be happening is that you run bokken.bat and that spawned another window for a second, could it be? Please explain the problem more thoroughly.

ANSI sequences have been fixed in a2aab07c3909.

#5 Updated by Vladimir Martyanov over 4 years ago

It seems I used a wrong phrase :-( In my previous comment was my point of view how it should be.

#6 Updated by David Martínez Moreno over 4 years ago

Yes, I got that, don't worry.

But you didn't answer my question. Please describe the bug in detail because if it is what I think, it's really easy to fix.

#7 Updated by Vladimir Martyanov over 4 years ago

I have GTK installed and I don't have any cores: no pyew and no radare2.
I started bokken from commandline and saw only console output: "... You need at least one core, either pyew or radare ...".
I started bokken from fluxbox and didn't see anythong.

As I think the problems are: Absence of GTK message about "No backend engines found!" despite the code for it (ui/main.py:76-82). The second problem is what you showed me: no output at all if bokken was started from windowing environment.

#8 Updated by Vladimir Martyanov over 4 years ago

Diffs to fix it attached. I also moved HAS_PYEW and HAS_RADARE to bokken_globals.py

Also available in: Atom PDF